tthorpeIBM commented on code in PR #3799: URL: https://github.com/apache/hive/pull/3799#discussion_r1029714700
########## standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/DatabaseProduct.java: ########## @@ -93,10 +100,6 @@ public static DatabaseProduct determineDatabaseProduct(String productName, // Check for null again in case of race condition if (theDatabaseProduct == null) { - Preconditions.checkNotNull(conf, "Configuration is null"); Review Comment: I omitted the null configuration check in my original commit. I have added it back but it was moved to line 80 right before it is needed before using the configuration to determine whether we have ConfVars.USE_CUSTOM_RDBMS set. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org