deniskuzZ commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1032295454
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorFactory.java:
##########
@@ -28,17 +30,23 @@
/**
* Simple factory class, which returns an instance of {@link QueryCompactor}.
*/
-final class QueryCompactorFactory {
- static final private Logger LOG =
LoggerFactory.getLogger(QueryCompactorFactory.class.getName());
+public final class CompactorFactory {
+ static final private Logger LOG =
LoggerFactory.getLogger(CompactorFactory.class.getName());
+
+ private static final CompactorFactory INSTANCE = new CompactorFactory();
Review Comment:
why do you need an instance of the factory? check Factory Design Pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
