veghlaci05 commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1033451506
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -273,6 +273,7 @@ public CompactionInfo
findNextToCompact(FindNextCompactRequest rqst) throws Meta
info.type =
TxnUtils.dbCompactionType2ThriftType(rs.getString(5).charAt(0));
info.poolName = rs.getString(6);
info.properties = rs.getString(7);
+ info.workerId = rqst.getWorkerId();
Review Comment:
Yes, this is required due to moving MrCompactor behind CompactorFactory. See
MrCompactor:
`
public void run(HiveConf conf, Table t, StorageDescriptor sd,
ValidWriteIdList writeIds,
CompactionInfo ci, IMetaStoreClient msc, AcidDirectory dir)
throws IOException {
String jobName = ci.workerId + "-compactor-" + ci.getFullPartitionName();
`
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -273,6 +273,7 @@ public CompactionInfo
findNextToCompact(FindNextCompactRequest rqst) throws Meta
info.type =
TxnUtils.dbCompactionType2ThriftType(rs.getString(5).charAt(0));
info.poolName = rs.getString(6);
info.properties = rs.getString(7);
+ info.workerId = rqst.getWorkerId();
Review Comment:
Yes, this is required due to moving MrCompactor behind CompactorFactory. See
MrCompactor:
`
public void run(HiveConf conf, Table t, StorageDescriptor sd,
ValidWriteIdList writeIds,
CompactionInfo ci, IMetaStoreClient msc, AcidDirectory dir)
throws IOException {
String jobName = ci.workerId + "-compactor-" + ci.getFullPartitionName();
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
