abstractdog commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1041219149
##########
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskCommunicator.java:
##########
@@ -584,6 +581,17 @@ public void indicateError(Throwable t) {
});
}
+ /**
+ * This is a best effort action in case of an invalid LLAP_TOKEN. The
communicator (LlapProtocolClientProxy) periodically
+ * refreshes tokens, but there is a relatively small time window (compared
to the whole token maxLifetime),
+ * when the token is cancelled and it's not yet fetched from daemons. By the
time we detect this problem, the current
+ * task attempt is already failed, but usually there are at least 3 task
attempts before failing the task and dag, therefore
+ * fetching an LLAP_TOKEN synchronously here definitely solves the invalid
token problem (as the next task attempt will use it).
+ */
+ private void handleInvalidToken(Throwable t) {
+ this.communicator.refreshToken();
Review Comment:
ack, it's just a leftover
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
