abstractdog commented on code in PR #3626:
URL: https://github.com/apache/hive/pull/3626#discussion_r1041242965
##########
llap-common/src/java/org/apache/hadoop/hive/llap/security/LlapTokenSelector.java:
##########
@@ -30,6 +30,9 @@
public class LlapTokenSelector implements TokenSelector<LlapTokenIdentifier> {
private static final Logger LOG =
LoggerFactory.getLogger(LlapTokenSelector.class);
+ public LlapTokenSelector() {
+ }
+
Review Comment:
maybe leftover, I remember I needed it for making TOKEN auth work
(reflection stuff in hadoop maybe), but now I cannot find any proof in hadoop
code that it's needed LOL
I'm testing without the constructor, if it works, I'll remove, if it's
needed, I'll put code comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
