SourabhBadhya opened a new pull request, #3876:
URL: https://github.com/apache/hive/pull/3876
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/Hive/HowToContribute
2. Ensure that you have created an issue on the Hive project JIRA:
https://issues.apache.org/jira/projects/HIVE/summary
3. Ensure you have added or run the appropriate tests for your PR:
4. If the PR is unfinished, add '[WIP]' in your PR title, e.g.,
'[WIP]HIVE-XXXXX: Your PR title ...'.
5. Be sure to keep the PR description updated to reflect all changes.
6. Please write your PR title to summarize what this PR proposes.
7. If possible, provide a concise example to reproduce the issue for a
faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section
is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster
reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class
hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other
DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The 3 tests in TestCrudCompactorOnTez which use the ProtoLoggingHook run at
different times. Unfortunately, the 3 tests are run at the following times as
described in the logs -
Test 1 -
`2022-12-15T16:57:44,294 INFO [main] compactor.TestCrudCompactorOnTez:
Current time: 2022-12-15T23:57:44 `
Test 2 -
`2022-12-15T17:00:32,452 INFO [main] compactor.TestCrudCompactorOnTez:
Current time: 2022-12-16T00:00:32 `
Test 3 -
`2022-12-15T17:04:12,895 INFO [main] compactor.TestCrudCompactorOnTez:
Current time: 2022-12-16T00:04:12 `
As we can see, the tests are run on 2 different dates. Therefore,
HiveProtoLoggingHook generates a unique event logs for every unique date. This
is the behaviour of HiveProtoLoggingHook.
https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/hooks/HiveProtoLoggingHook.java#L296-L310
However the expectation from the test side, while generating the log readers
is that there must be a single file in the log folder defined.
https://github.com/apache/hive/blob/master/ql/src/test/org/apache/hadoop/hive/ql/hooks/TestHiveProtoLoggingHook.java#L310
Unfortunately, since there are 2 files which are generated (as mentioned in
the logs as well), the following tests fail -
```
2022-12-15T17:04:14,837 INFO [main] hooks.TestHiveProtoLoggingHook: List of
paths:
2022-12-15T17:04:14,837 INFO [main] hooks.TestHiveProtoLoggingHook:
file:/home/jenkins/agent/workspace/internal-hive-flaky-check/itests/hive-unit/target/tmp/junit441259831997042392/junit3438435196942546140/date=2022-12-15
2022-12-15T17:04:14,837 INFO [main] hooks.TestHiveProtoLoggingHook:
file:/home/jenkins/agent/workspace/internal-hive-flaky-check/itests/hive-unit/target/tmp/junit441259831997042392/junit3438435196942546140/date=2022-12-16
```
The solution is to make getTestReader() in TestHiveProtoLoggingHook more
compatible with multiple event log file scenario and be able to generate
multiple readers for all files present in the folder instead of fixating on a
single file clause.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix this flakiness in TestCrudCompactorOnTez
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as
the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes
- provide the console output, description, screenshot and/or a reproducable
example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to
the released Hive versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some
test cases that check the changes thoroughly including negative and positive
cases if possible.
If it was tested in a way different from regular unit tests, please clarify
how you tested step by step, ideally copy and paste-able, so that other
reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why
it was difficult to add.
-->
Existing unit tests are sufficient
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
