zabetak commented on code in PR #3886:
URL: https://github.com/apache/hive/pull/3886#discussion_r1059967623
##########
service/pom.xml:
##########
@@ -291,13 +291,6 @@
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.directory.client.ldap</groupId>
- <artifactId>ldap-client-api</artifactId>
- <version>${apache-directory-clientapi.version}</version>
- <scope>test</scope>
- </dependency>
-
<dependency>
<groupId>org.apache.directory.server</groupId>
<artifactId>apacheds-server-integ</artifactId>
Review Comment:
Can you clarify why we don't want to exclude `ldap-client-api` from here as
it was done in the original commit in master
(https://github.com/apache/hive/commit/5581eb8a74a4f33b35b7bf70d9ec4e9a95f3b8a0).
When I run `mvn dependency:tree` in service module I see the
`org.apache.directory.client.ldap:ldap-client-api` dependency coming
transitively.
```
[INFO] +- org.apache.directory.server:apacheds-server-integ:jar:1.5.7:test
[INFO] | +-
org.apache.directory.server:apacheds-interceptor-kerberos:jar:1.5.7:test
[INFO] | | +- org.apache.directory.server:apacheds-core:jar:1.5.7:test
[INFO] | | | +-
org.apache.directory.server:apacheds-core-api:jar:1.5.7:test
[INFO] | | | | +-
org.apache.directory.server:apacheds-core-entry:jar:1.5.7:test
[INFO] | | | | \-
org.apache.directory.server:apacheds-core-constants:jar:1.5.7:test
[INFO] | | | +- org.apache.directory.server:apacheds-utils:jar:1.5.7:test
[INFO] | | | \- bouncycastle:bcprov-jdk15:jar:140:test
[INFO] | | \-
org.apache.directory.server:apacheds-kerberos-shared:jar:1.5.7:test
[INFO] | | +-
org.apache.directory.server:apacheds-core-jndi:jar:1.5.7:test
[INFO] | | \-
org.apache.directory.server:apacheds-protocol-shared:jar:1.5.7:test
[INFO] | +- org.apache.directory.server:apacheds-core-integ:jar:1.5.7:test
[INFO] | +- ldapsdk:ldapsdk:jar:4.1:test
[INFO] | +- org.apache.directory.client.ldap:ldap-client-api:jar:0.1:test
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
