cnauroth commented on code in PR #3886:
URL: https://github.com/apache/hive/pull/3886#discussion_r1060901243
##########
service/pom.xml:
##########
@@ -291,13 +291,6 @@
<scope>test</scope>
</dependency>
- <dependency>
- <groupId>org.apache.directory.client.ldap</groupId>
- <artifactId>ldap-client-api</artifactId>
- <version>${apache-directory-clientapi.version}</version>
- <scope>test</scope>
- </dependency>
-
<dependency>
<groupId>org.apache.directory.server</groupId>
<artifactId>apacheds-server-integ</artifactId>
Review Comment:
Commit 5581eb8a74a4f33b35b7bf70d9ec4e9a95f3b8a0 actually removed the
exclusion from the existing codebase. This exclusion is not present in
branch-3, so there isn't anything for this patch to remove.
If I run `mvn dependency:tree` on master, I see the same transitive
dependency. Looking back on the history of
[HIVE-21836](https://issues.apache.org/jira/browse/HIVE-21836), I see there was
a Jenkins run for HIVE-21836.01.patch, which did not remove the exclusion, and
it had a test failure in `TestLdapAtnProviderWithMiniDS`. Then,
HIVE-21836.02.patch removed the exclusion, and it got a successful Jenkins run.
I can't reproduce that problem though. I tried adding the exclusion back, and
the test still passed fine for me.
Let me know if you think we should bring back this exclusion on both master
and branch-3. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
