deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1062308121
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java:
##########
@@ -3227,6 +3227,15 @@ void commitTxn(CommitTxnRequest rqst)
*/
void abortTxns(List<Long> txnids) throws TException;
+ /**
+ * Abort a list of transactions with additional information of
+ * errorcodes as defined in TxnErrorMsg.java.
+ * @param txnids List of transaction ids
+ * @param errorCode Error code specifying the reason for abort.
+ * @throws TException
+ */
+ void abortTxns(List<Long> txnids, long errorCode) throws TException;
Review Comment:
we should make this method generic and use Request object here as well, see
````
CompactionResponse compact2(CompactionRequest request)
void dropDatabase(DropDatabaseRequest req)
````
etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
