deniskuzZ commented on code in PR #3908:
URL: https://github.com/apache/hive/pull/3908#discussion_r1062323607
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java:
##########
@@ -5144,6 +5159,7 @@ private int abortTxns(Connection dbConn, List<Long>
txnids, boolean checkHeartbe
if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON)) {
Metrics.getOrCreateCounter(MetricsConstants.TOTAL_NUM_ABORTED_TXNS).inc(txnids.size());
}
+ LOG.info("Txns are aborted successfully due to : {}", errorMsg);
Review Comment:
The error message is not informative: something aborted because of ...
Maybe print ids of aborted txns? Make sure we are not doing unnecessary
logging. see
````
performTimeOuts()
LOG.info("Aborted the following transactions due to timeout: {}",
batchToAbort.toString());
LOG.info("Aborted {} transactions due to timeout", numTxnsAborted);
````
and
````
commitTxn()
String msg = "Aborting [" + JavaUtils.txnIdToString(txnid) + "," + commitId
+ "]" + " due to a write conflict on " + resource +
" committed by " + committedTxn + " " +
rs.getString(7) + "/" + rs.getString(8);
````
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
