amansinha100 commented on code in PR #3852:
URL: https://github.com/apache/hive/pull/3852#discussion_r1067785222
##########
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java:
##########
@@ -3710,7 +3710,12 @@ public static enum ConfVars {
HIVE_EXPLAIN_USER("hive.explain.user", true,
"Whether to show explain result at user level.\n" +
"When enabled, will log EXPLAIN output for the query at user level.
Tez only."),
-
+ HIVE_EXPLAIN_VISIT_LIMIT("hive.explain.visit.limit", 256, new
RangeValidator(1, Integer.MAX_VALUE),
Review Comment:
Does this limit actually only apply when doing an EXPLAIN ? Even if the
query is not explicitly doing an explain, the limit should still apply during
compilation right ? Also, the explain plan is written to the log file so we
would want to avoid writing huge plans there. It seems to me a better config
would be 'hive.compile.node.visit.limit'.
##########
ql/src/test/results/clientpositive/llap/lvj_mapjoin.q.out:
##########
@@ -121,7 +121,6 @@ STAGE PLANS:
TableScan
alias: expod1
filterExpr: aid is not null (type: boolean)
- probeDecodeDetails: cacheKey:HASH_MAP_MAPJOIN_39_container,
bigKeyColName:aid, smallTablePos:1, keyRatio:1.0
Review Comment:
I didn't understand why this part of the plan changed.
##########
ql/src/java/org/apache/hadoop/hive/ql/ppd/SyntheticJoinPredicate.java:
##########
@@ -94,8 +95,8 @@ public ParseContext transform(ParseContext pctx) throws
SemanticException {
// rule and passes the context along
SyntheticContext context = new SyntheticContext(pctx);
SemanticDispatcher disp = new DefaultRuleDispatcher(null, opRules,
context);
- SemanticGraphWalker ogw = new PreOrderOnceWalker(disp);
-
+ PreOrderOnceWalker ogw = new PreOrderOnceWalker(disp);
+ ogw.excludeNode(LateralViewForwardOperator.class);
Review Comment:
Pls add a comment about why the LVF operator is treated in a special way in
the context of SyntheticJoinPredicate. The description in the Jira is nice but
would be useful to have a summarized couple of lines here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
