ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1040356751
##########
llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java:
##########
@@ -61,7 +61,7 @@
import org.apache.orc.impl.TreeReaderFactory.TreeReader;
import org.apache.orc.impl.WriterImpl;
import org.apache.orc.OrcProto;
-
+import org.apache.orc.impl.reader.tree.TypeReader;
Review Comment:
import order is wrong. Imports should be alphabetically sorted
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -1249,10 +1534,13 @@ public void seek(PositionProvider index) throws
IOException {
}
@Override
- public void nextVector(
- ColumnVector previousVector, boolean[] isNull, int batchSize) throws
IOException {
+ public void nextVector(ColumnVector previousVector,
+ boolean[] isNull,
+ final int batchSize,
+ FilterContext filterContext,
+ ReadPhase readPhase) throws IOException {
Review Comment:
this code doesn't look formatted
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Why is this added in scope of upgrade?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
