ayushtkn commented on code in PR #3833:
URL: https://github.com/apache/hive/pull/3833#discussion_r1071751361
##########
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java:
##########
@@ -224,7 +237,252 @@ private static void skipCompressedIndex(boolean
isCompressed, PositionProvider i
index.getNext();
}
- protected static class StringStreamReader extends StringTreeReader
+ public static class StringDictionaryTreeReaderHive extends TreeReader {
Review Comment:
Ok, that seems to be an improvement or say a bug fix in the ORC project and
we are just implementing our own varient because now the original class is
causing test failures.
This isn't the ideal approach and will backfire in future when we try to
upgrade and the changes in ORC depends on the ones which we ditched.
We should try to adapt to those changes and make sure we don't crash with
those changes in Hive by making hive changes, rather than maintaining a old
version of ORC class at Hive
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
