soumyakanti3578 commented on code in PR #3982:
URL: https://github.com/apache/hive/pull/3982#discussion_r1088264787
##########
ql/src/test/queries/clientpositive/udf_convert_charset.q:
##########
@@ -0,0 +1,9 @@
+DESCRIBE FUNCTION convertCharset;
+DESC FUNCTION EXTENDED convertCharset;
+
+explain select convertCharset('TestConvertCharset1', 'UTF-8', 'US-ASCII');
+
+select
+convertCharset('TestConvertCharset1', 'UTF-8', 'US-ASCII'),
+convertCharset('TestConvertCharset2', cast('UTF-8' as varchar(10)),
'US-ASCII'),
+convertCharset('TestConvertCharset3', cast('UTF-8' as char(5)), 'US-ASCII');
Review Comment:
nit: please add a new line at the end of the file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
