deniskuzZ commented on code in PR #4032:
URL: https://github.com/apache/hive/pull/4032#discussion_r1118384775
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java:
##########
@@ -57,15 +50,15 @@ public class MetaStoreCompactorThread extends
CompactorThread implements MetaSto
protected TxnStore txnHandler;
protected ScheduledExecutorService cycleUpdaterExecutorService;
-
- private Optional<Cache<String, TBase>> metaCache = Optional.empty();
+ protected CacheContainer cacheContainer;
@Override
public void init(AtomicBoolean stop) throws Exception {
super.init(stop);
// Get our own instance of the transaction handler
txnHandler = TxnUtils.getTxnStore(conf);
+ cacheContainer = new CacheContainer();
Review Comment:
shouldn't it be a singleton? why do we need multiple cache instances for
Initiator & Cleaner?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
