SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1119559393
########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/MetaStoreCompactorThread.java: ########## @@ -57,15 +50,15 @@ public class MetaStoreCompactorThread extends CompactorThread implements MetaSto protected TxnStore txnHandler; protected ScheduledExecutorService cycleUpdaterExecutorService; - - private Optional<Cache<String, TBase>> metaCache = Optional.empty(); + protected CacheContainer cacheContainer; @Override public void init(AtomicBoolean stop) throws Exception { super.init(stop); // Get our own instance of the transaction handler txnHandler = TxnUtils.getTxnStore(conf); + cacheContainer = new CacheContainer(); Review Comment: As discussed, the cached instances are invalidated both on Initiator and Cleaner side. There might also be staleness of table object if properties of the table are changed in the time between Initiator & Cleaner. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org