SourabhBadhya commented on code in PR #4032: URL: https://github.com/apache/hive/pull/4032#discussion_r1122945511
########## ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/Cleaner.java: ########## @@ -97,23 +46,28 @@ public class Cleaner extends MetaStoreCompactorThread { static final private Logger LOG = LoggerFactory.getLogger(CLASS_NAME); private boolean metricsEnabled = false; - private ReplChangeManager replChangeManager; private ExecutorService cleanerExecutor; + private List<RequestHandler> requestHandlers; @Override public void init(AtomicBoolean stop) throws Exception { super.init(stop); - replChangeManager = ReplChangeManager.getInstance(conf); checkInterval = conf.getTimeVar( HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_RUN_INTERVAL, TimeUnit.MILLISECONDS); - cleanerExecutor = CompactorUtil.createExecutorWithThreadFactory( - conf.getIntVar(HiveConf.ConfVars.HIVE_COMPACTOR_CLEANER_THREADS_NUM), - COMPACTOR_CLEANER_THREAD_NAME_FORMAT); metricsEnabled = MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.METRICS_ENABLED) && MetastoreConf.getBoolVar(conf, MetastoreConf.ConfVars.METASTORE_ACIDMETRICS_EXT_ON); - boolean tableCacheOn = MetastoreConf.getBoolVar(conf, - MetastoreConf.ConfVars.COMPACTOR_CLEANER_TABLECACHE_ON); - initializeCache(tableCacheOn); + if (CollectionUtils.isEmpty(requestHandlers)) { Review Comment: Yes this is required for tests -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org