deniskuzZ commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1126066261
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java:
##########
@@ -116,6 +116,13 @@ private static TableScan createTableScan(Table table,
Configuration conf) {
scan = scan.useSnapshot(snapshotId);
}
+ if (snapshotId == -1) {
+ long snapshotIntervalFrom =
conf.getLong(InputFormatConfig.SNAPSHOT_INTERVAL_FROM, -1);
+ if (snapshotIntervalFrom != -1) {
+ scan = scan.appendsBetween(snapshotIntervalFrom,
table.currentSnapshot().snapshotId());
Review Comment:
this API is deprecated, I don't think we should build something on it. Could
we use `newIncrementalAppendScan`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
