deniskuzZ commented on code in PR #4079:
URL: https://github.com/apache/hive/pull/4079#discussion_r1126057550
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergInputFormat.java:
##########
@@ -142,6 +142,7 @@ public InputSplit[] getSplits(JobConf job, int numSplits)
throws IOException {
job.getBoolean(ColumnProjectionUtils.FETCH_VIRTUAL_COLUMNS_CONF_STR, false));
job.set(InputFormatConfig.AS_OF_TIMESTAMP,
job.get(TableScanDesc.AS_OF_TIMESTAMP, "-1"));
job.set(InputFormatConfig.SNAPSHOT_ID,
job.get(TableScanDesc.AS_OF_VERSION, "-1"));
+ job.set(InputFormatConfig.SNAPSHOT_INTERVAL_FROM,
job.get(TableScanDesc.VERSION_INTERVAL_FROM, "-1"));
Review Comment:
`SNAPSHOT_INTERVAL_FROM` should we add a version marker into the config name
if we'll support timestamp interval as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
