pan3793 commented on code in PR #4150:
URL: https://github.com/apache/hive/pull/4150#discussion_r1147940693


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -402,6 +402,8 @@ public enum ConfVars {
             "has an infinite lifetime."),
     CLIENT_SOCKET_TIMEOUT("metastore.client.socket.timeout", 
"hive.metastore.client.socket.timeout", 600,
             TimeUnit.SECONDS, "MetaStore Client socket timeout in seconds"),
+    CLIENT_CONNECTION_TIMEOUT("metastore.client.connection.timeout", 
"hive.metastore.client.connection.timeout", 10,

Review Comment:
   It makes sense to set connection timeout a small value, because generally, 
establish the connection is quick, and small timeout make it quick failover if 
one HMS is down, but it silent changes the default behavior, I'm not sure if 
such change is acceptable in Hive community



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to