deniskuzZ commented on code in PR #4150:
URL: https://github.com/apache/hive/pull/4150#discussion_r1175784708


##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -402,6 +402,8 @@ public enum ConfVars {
             "has an infinite lifetime."),
     CLIENT_SOCKET_TIMEOUT("metastore.client.socket.timeout", 
"hive.metastore.client.socket.timeout", 600,
             TimeUnit.SECONDS, "MetaStore Client socket timeout in seconds"),
+    CLIENT_CONNECTION_TIMEOUT("metastore.client.connection.timeout", 
"hive.metastore.client.connection.timeout", 10,

Review Comment:
   @wecharyu, won't be socketTimeout = connectTimeout if not explicitly set?
   {code}
   public TSocket(TConfiguration config, String host, int port, int timeout)  {
       this(config, host, port, timeout, timeout);
     }
   public TSocket(TConfiguration config, String host, int port, int 
socketTimeout, int connectTimeout)  {}
   {code}



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to