jfsii commented on PR #4197: URL: https://github.com/apache/hive/pull/4197#issuecomment-1499205070
> LGTM! > > I am +2 as it is but if had a test that goes along I would be +100 :) > > Would it be feasible/easy to do something similar to `TestHiveMetaStoreClientApiArgumentsChecker` where we have a fake `IMetaStoreClient` that throws and then put `Hive.loadDynamicPartitions` under test? If it is too complicated I am perfectly fine merging this as is. @zabetak I can certainly try - if it turns out that it becomes too complex for the benefit, I'll say something. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
