jfsii commented on PR #4197: URL: https://github.com/apache/hive/pull/4197#issuecomment-1507226781
Re: @zabetak I think I'd like to give up on writing the test. I attempted for a few hours but found it hard to mock up objects to be able to call loadDynamicPartitions, I could take a different approach and use mockito or something but I'm not sure it is worth it to do at this time. I also need to work on some other items and do not want to forget about this patch. Feel free to re-push back and I will try to make the time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
