saihemanth-cloudera commented on code in PR #4282:
URL: https://github.com/apache/hive/pull/4282#discussion_r1191500115
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -1008,6 +1016,10 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory()
throws SQLException {
JdbcConnectionParams.SUNJSSE_ALGORITHM_STRING);
String keyStorePath =
sessConfMap.get(JdbcConnectionParams.SSL_KEY_STORE);
String keyStorePassword =
sessConfMap.get(JdbcConnectionParams.SSL_KEY_STORE_PASSWORD);
+ if (keyStorePassword == null) {
+ keyStorePassword = Utils.getPasswordFromCredentialProvider(
Review Comment:
Can we move all these three types of passwords to a different API? This API
can take in the `String key` as a parameter and return a string password. You
can then call the API at lines #900, #1018, and #1037.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
