VenuReddy2103 commented on code in PR #4282:
URL: https://github.com/apache/hive/pull/4282#discussion_r1192439999
##########
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java:
##########
@@ -1008,6 +1016,10 @@ SSLConnectionSocketFactory getTwoWaySSLSocketFactory()
throws SQLException {
JdbcConnectionParams.SUNJSSE_ALGORITHM_STRING);
String keyStorePath =
sessConfMap.get(JdbcConnectionParams.SSL_KEY_STORE);
String keyStorePassword =
sessConfMap.get(JdbcConnectionParams.SSL_KEY_STORE_PASSWORD);
+ if (keyStorePassword == null) {
+ keyStorePassword = Utils.getPasswordFromCredentialProvider(
Review Comment:
> Seems like we load all credentials from the same creds file, is this by
design?
>
> And we can add some comment how to use the `key` to generate the local
creds, looks like we use `JdbcConnectionParams.SSL_KEY_STORE_PASSWORD` as the
key.
Yes. We store all the passwords in the same file. Will document about the
generation and usage in cwiki
https://cwiki.apache.org/confluence/display/Hive/HiveServer2+Clients
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
