SourabhBadhya commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1197368328


##########
ql/src/test/org/apache/hadoop/hive/ql/txn/compactor/CompactorTest.java:
##########
@@ -129,6 +130,7 @@ public abstract class CompactorTest {
   FileSystem fs;
   
   @Before
+  @BeforeEach

Review Comment:
   Junit 4 & Junit 5 tests are present in the compaction related tests. Hence 
have to use both the annotations. I think its best to address moving compaction 
related tests from Junit 4 to Junit 5 tests in a separate Jira since this PR 
does not have such intentions to change it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to