SourabhBadhya commented on code in PR #4313:
URL: https://github.com/apache/hive/pull/4313#discussion_r1198519872
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java:
##########
@@ -1562,16 +1620,46 @@ public void markRefused(CompactionInfo info) throws
MetaException {
@Override
@RetrySemantics.CannotRetry
- public void setCleanerRetryRetentionTimeOnError(CompactionInfo info) throws
MetaException {
+ public void setCleanerRetryRetentionTimeOnError(CompactionInfo info, boolean
isAbort) throws MetaException {
Review Comment:
I had created a separate generic class from which CompactionInfo derives
from in #4091 , however it was pulled out in review phase by @deniskuzZ .
https://github.com/apache/hive/pull/4091#discussion_r1161666811
I will wait till @deniskuzZ advises on whether a separate class needs to be
created or reuse CompactionInfo before fixing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
