ayushtkn commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1199923529
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -122,7 +123,8 @@ public class MetaStoreServerUtils {
private static final Logger LOG =
LoggerFactory.getLogger(MetaStoreServerUtils.class);
public static final String JUNIT_DATABASE_PREFIX = "junit_metastore_db";
-
+ public static final String TABLE_TYPE_PROP = "table_type";
+ public static final String ICEBERG_TABLE_TYPE_VALUE = "iceberg";
Review Comment:
no need to define again, they are defined here, can use the same
```
import static org.apache.hadoop.hive.metastore.HiveMetaHook.ICEBERG;
import static org.apache.hadoop.hive.metastore.HiveMetaHook.TABLE_TYPE;
```
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/utils/MetaStoreServerUtils.java:
##########
@@ -546,9 +548,17 @@ public static void
updateTableStatsForCreateTable(Warehouse wh, Database db, Tab
}
}
- if (MetastoreConf.getBoolVar(conf,
MetastoreConf.ConfVars.STATS_AUTO_GATHER)) {
+ boolean isIcebergTable = Optional.ofNullable(tbl.getParameters())
+ .orElse(Collections.emptyMap())
+ .getOrDefault(TABLE_TYPE_PROP, "undefined")
+ .equals(ICEBERG_TABLE_TYPE_VALUE);
Review Comment:
Does ``statsSetup.isIcebergTable`` doesn't tell you it is a ``iceberg``
table?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
