difin commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1211675690
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/StatsSetupConst.java:
##########
@@ -173,6 +173,10 @@ public String getAggregator(Configuration conf) {
public static final String FALSE = "false";
+ public static final String HIVE_ICEBERG_STATS_SOURCE =
"hive.iceberg.stats.source";
Review Comment:
HiveConf exists in hive-common module which is not a dependency of metastore
server.
I saw some instances in HiveMetsStoreClient where other constants of
HiveConf where hardcoded.
So I assumed that Hive Metastore doesn't want to depend on hive-common.
Probably because HMS is used not only by Hive?
Please let me know if my understanding is incorrect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
