deniskuzZ commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1200777000
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java:
##########
@@ -1751,15 +1751,22 @@ public Table getTable(final String dbName, final String
tableName, String metaTa
}
Table t = new Table(tTable);
- if (metaTableName != null) {
- if (t.getStorageHandler() == null ||
!t.getStorageHandler().isMetadataTableSupported()) {
- throw new SemanticException(ErrorMsg.METADATA_TABLE_NOT_SUPPORTED,
t.getTableName());
+ if (tableIdentifier != null) {
+ if (t.getStorageHandler() == null ||
!t.getStorageHandler().isTableIdentifierSupported()) {
+ throw new SemanticException(ErrorMsg.TABLE_IDENTIFIER_NOT_SUPPORTED,
t.getTableName());
}
- if (!t.getStorageHandler().isValidMetadataTable(metaTableName)) {
- throw new SemanticException(ErrorMsg.INVALID_METADATA_TABLE_NAME,
metaTableName);
+ if (tableIdentifier.startsWith("branch_")) {
Review Comment:
please move string literal "branch_" to constant
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
