deniskuzZ commented on code in PR #4292: URL: https://github.com/apache/hive/pull/4292#discussion_r1201936910
########## ql/src/java/org/apache/hadoop/hive/ql/parse/HiveTableName.java: ########## @@ -106,6 +106,18 @@ public static TableName ofNullable(String dbTableName, String defaultDb) throws } } + public static TableName ofNullable(String dbTableName, String defaultDb, String branchName) throws SemanticException { Review Comment: why don't you reuse new signature in `ofNullable(String dbTableName, String defaultDb)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org