ayushtkn commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1213922691
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveUtils.java:
##########
@@ -107,6 +109,7 @@ public static String escapeString(String str) {
static final byte[] tabEscapeBytes = "\\t".getBytes();;
static final byte[] tabUnescapeBytes = "\t".getBytes();
static final byte[] ctrlABytes = "\u0001".getBytes();
+ static final Pattern BRANCH = Pattern.compile("branch_(.*)");
Review Comment:
If table name or database name has branch? Will this work?
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -550,14 +550,19 @@ default boolean isTimeTravelAllowed() {
return false;
}
- default boolean isMetadataTableSupported() {
+ default boolean isTableMetaRefSupported() {
return false;
}
Review Comment:
Isn't this an incompatible change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
