zhangbutao commented on code in PR #4292:
URL: https://github.com/apache/hive/pull/4292#discussion_r1214000613
##########
ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveStorageHandler.java:
##########
@@ -550,14 +550,19 @@ default boolean isTimeTravelAllowed() {
return false;
}
- default boolean isMetadataTableSupported() {
+ default boolean isTableMetaRefSupported() {
return false;
}
Review Comment:
ha, i am not obect to keep the method as it is. Let me give some thought.
The `isMetadataTableSupported()` is only used here
https://github.com/apache/hive/pull/4292/files#diff-9d6bc2f1a2972d844b3107f29bc1731af7adf6f4c922e08904345c5ae88cd727L1755,
and then `storagehandler::isValidMetadataTable` will check the metadata table
if is valid.
That is to say, the actual effect of method `isMetadataTableSupported()`
is just simply to verify that the table has three layer identifier
`database.table.tableRef`, and the final check occurs in
`storagehandler::isValidMetadataTable`. And i rename it from
`isMetadataTableSupported()` to `isTableMetaRefSupported()` to make its
three_layer_identifier meaning more general, not just for metadata table.
But maybe i am not good at naming & renaming method. If you think we should
keep hte name as is or using another method name, please feel free to give
advice. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
