zhangbutao commented on code in PR #4397:
URL: https://github.com/apache/hive/pull/4397#discussion_r1223239623
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -220,8 +220,10 @@ public int persistColumnStats(Hive db, Table tbl) throws
HiveException, MetaExce
start = System. currentTimeMillis();
if (tbl != null && tbl.isNonNative() &&
tbl.getStorageHandler().canSetColStatistics(tbl)) {
tbl.getStorageHandler().setColStatistics(tbl, colStats);
+ } else {
+ // Set table or partition column statistics in metastore.
+ db.setPartitionColumnStatistics(request);
}
- db.setPartitionColumnStatistics(request);
Review Comment:
I'm a little confused about the change.
If we can not get stats from puffine due to some exception, we can fallback
get stats from metastore. So i think maybe write stats into the two places is
meaningful. Please correct me if i misunderstand. Thansk.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
