zhangbutao commented on code in PR #4397:
URL: https://github.com/apache/hive/pull/4397#discussion_r1225289195
##########
ql/src/java/org/apache/hadoop/hive/ql/stats/ColStatsProcessor.java:
##########
@@ -220,8 +220,10 @@ public int persistColumnStats(Hive db, Table tbl) throws
HiveException, MetaExce
start = System. currentTimeMillis();
if (tbl != null && tbl.isNonNative() &&
tbl.getStorageHandler().canSetColStatistics(tbl)) {
tbl.getStorageHandler().setColStatistics(tbl, colStats);
+ } else {
+ // Set table or partition column statistics in metastore.
+ db.setPartitionColumnStatistics(request);
}
- db.setPartitionColumnStatistics(request);
Review Comment:
https://github.com/apache/hive/blob/10600392ec05bd50351b4668b38dd84502a7eb72/ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java#L308-L311
https://github.com/apache/hive/blob/10600392ec05bd50351b4668b38dd84502a7eb72/ql/src/java/org/apache/hadoop/hive/ql/optimizer/StatsOptimizer.java#L932-L950
Currently, Like this example HIVE-27347 always uses the iceberg basic stats
from metatstore to optimize` count(*)` query. We should consider how to do this
if only using puffin stats.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
