ayushtkn commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1235143595


##########
iceberg/iceberg-catalog/pom.xml:
##########
@@ -74,5 +78,10 @@
       <artifactId>junit-vintage-engine</artifactId>
       <scope>test</scope>
     </dependency>
+    <dependency>
+      <groupId>org.mockito</groupId>
+      <artifactId>mockito-core</artifactId>
+      <scope>test</scope>
+    </dependency>

Review Comment:
   why was this required? Which test fails without this? As of now it is 
inheriting from parent POM, Shouldn't we use     
   ```
   <iceberg.mockito-core.version>3.4.4</iceberg.mockito-core.version> 
   ```
   version?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to