deniskuzZ commented on code in PR #4291:
URL: https://github.com/apache/hive/pull/4291#discussion_r1235176904
##########
iceberg/iceberg-catalog/src/main/java/org/apache/iceberg/hive/MetastoreUtil.java:
##########
@@ -19,57 +19,61 @@
package org.apache.iceberg.hive;
+import java.util.Map;
import org.apache.hadoop.hive.common.StatsSetupConst;
import org.apache.hadoop.hive.metastore.IMetaStoreClient;
import org.apache.hadoop.hive.metastore.api.EnvironmentContext;
import org.apache.hadoop.hive.metastore.api.Table;
import org.apache.iceberg.common.DynMethods;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableMap;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
public class MetastoreUtil {
-
- // this class is unique to Hive3 and cannot be found in Hive2, therefore a
good proxy to see if
- // we are working against Hive3 dependencies
- private static final String HIVE3_UNIQUE_CLASS =
"org.apache.hadoop.hive.serde2.io.DateWritableV2";
-
- private static final DynMethods.UnboundMethod ALTER_TABLE =
DynMethods.builder("alter_table")
- .impl(IMetaStoreClient.class, "alter_table_with_environmentContext",
- String.class, String.class, Table.class, EnvironmentContext.class)
- .impl(IMetaStoreClient.class, "alter_table",
- String.class, String.class, Table.class, EnvironmentContext.class)
- .impl(IMetaStoreClient.class, "alter_table",
- String.class, String.class, Table.class)
+ private static final DynMethods.UnboundMethod ALTER_TABLE =
+ DynMethods.builder("alter_table")
+ .impl(
+ IMetaStoreClient.class,
+ "alter_table_with_environmentContext",
+ String.class,
+ String.class,
+ Table.class,
+ EnvironmentContext.class)
+ .impl(
+ IMetaStoreClient.class,
+ "alter_table",
+ String.class,
+ String.class,
+ Table.class,
+ EnvironmentContext.class)
+ .impl(IMetaStoreClient.class, "alter_table", String.class,
String.class, Table.class)
.build();
- private static final boolean HIVE3_PRESENT_ON_CLASSPATH = detectHive3();
Review Comment:
why did we remove this? it's present in upstream iceberg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
