difin commented on code in PR #4348:
URL: https://github.com/apache/hive/pull/4348#discussion_r1240087441


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -915,6 +915,10 @@ private void setCommonJobConf(JobConf jobConf) {
     jobConf.set("tez.mrreader.config.update.properties", 
"hive.io.file.readcolumn.names,hive.io.file.readcolumn.ids");
   }
 
+  public String getTableType(org.apache.hadoop.hive.ql.metadata.Table table) {

Review Comment:
   Table param is a typo which I didn't notice, I'll remove it. Also updated 
the solution to return `StorageFormat.StorageHandlerTypes.ICEBERG`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to