ayushtkn commented on code in PR #4441:
URL: https://github.com/apache/hive/pull/4441#discussion_r1241720602
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergStorageHandler.java:
##########
@@ -737,6 +746,22 @@ public void
executeOperation(org.apache.hadoop.hive.ql.metadata.Table hmsTable,
}
}
+ private static void expireSnapshotByIds(Table icebergTable, String[]
idsToExpire,
+ ExecutorService deleteExecutorService) {
+ if (idsToExpire.length != 0) {
+ ExpireSnapshots expireSnapshots = icebergTable.expireSnapshots();
+ for (String id : idsToExpire) {
Review Comment:
it will be successful, you wanted to get rid of a snapshot, it isn't there
already, so we are already sorted, it would expire the other ones & return
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
