deniskuzZ commented on code in PR #4441:
URL: https://github.com/apache/hive/pull/4441#discussion_r1259322276
##########
ql/src/java/org/apache/hadoop/hive/ql/ddl/table/execute/AlterTableExecuteAnalyzer.java:
##########
@@ -89,8 +90,13 @@ protected void analyzeCommand(TableName tableName,
Map<String, String> partition
ZoneId timeZone = SessionState.get() == null ? new
HiveConf().getLocalTimeZone() : SessionState.get().getConf()
.getLocalTimeZone();
- TimestampTZ time =
TimestampTZUtil.parse(PlanUtils.stripQuotes(child.getText()), timeZone);
- spec = new AlterTableExecuteSpec(EXPIRE_SNAPSHOT, new
ExpireSnapshotsSpec(time.toEpochMilli()));
+ String childText = PlanUtils.stripQuotes(child.getText().trim());
+ if (childText.contains(",") || StringUtils.isNumeric(childText)) {
Review Comment:
can we use regex match here? \d+(\s*,\s*\d+)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
