saihemanth-cloudera commented on code in PR #4416:
URL: https://github.com/apache/hive/pull/4416#discussion_r1247064540
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java:
##########
@@ -836,28 +835,24 @@ public void run() {
LeaderElectionContext context = new
LeaderElectionContext.ContextBuilder(conf)
.setHMSHandler(thriftServer.getHandler()).servHost(getServerHostName())
- // always tasks
- .setTType(LeaderElectionContext.TTYPE.ALWAYS_TASKS)
+ .setTType(LeaderElectionContext.TTYPE.ALWAYS_TASKS) // always
tasks
.addListener(new HouseKeepingTasks(conf, false))
- // housekeeping tasks
- .setTType(LeaderElectionContext.TTYPE.HOUSEKEEPING)
+ .setTType(LeaderElectionContext.TTYPE.HOUSEKEEPING) //
housekeeping tasks
.addListener(new CMClearer(conf))
.addListener(new StatsUpdaterTask(conf))
.addListener(new CompactorTasks(conf, false))
.addListener(new CompactorPMF())
.addListener(new HouseKeepingTasks(conf, true))
- // compactor worker
- .setTType(LeaderElectionContext.TTYPE.WORKER)
- .addListener(new CompactorTasks(conf, true),
MetastoreConf.getVar(conf,
-
MetastoreConf.ConfVars.HIVE_METASTORE_RUNWORKER_IN).equals("metastore"))
+ .setTType(LeaderElectionContext.TTYPE.WORKER) // compactor worker
+ .addListener(new CompactorTasks(conf, true),
+ MetastoreConf.getVar(conf,
MetastoreConf.ConfVars.HIVE_METASTORE_RUNWORKER_IN).equals("metastore"))
.build();
if (shutdownHookMgr != null) {
shutdownHookMgr.addShutdownHook(() -> context.close(), 0);
}
context.start();
} catch (Throwable e) {
- LOG.error("Failure when starting the leader tasks, compactions or
housekeeping tasks may not happen, " +
- StringUtils.stringifyException(e));
+ LOG.error("Compaction or Housekeeping tasks may not happen", e);
Review Comment:
Should we keep the previous logging message L#859? I think it gives more
details than the current suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
