saihemanth-cloudera commented on code in PR #4416:
URL: https://github.com/apache/hive/pull/4416#discussion_r1247088019
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/metastore/conf/MetastoreConf.java:
##########
@@ -566,11 +566,20 @@ public enum ConfVars {
METASTORE_HOUSEKEEPING_LEADER_ELECTION("metastore.housekeeping.leader.election",
"metastore.housekeeping.leader.election",
"host", new StringSetValidator("host", "lock"),
- "If sets to host, HMS will choose the leader by the configured
metastore.housekeeping.leader.hostname.\n" +
- "When configured to lock, HMS will use hive locks to elect the
leader."),
+ "Set to host, HMS will choose the leader by the configured
metastore.housekeeping.leader.hostname.\n" +
+ "Set to lock, HMS will use the hive lock to elect the leader."),
METASTORE_HOUSEKEEPING_LEADER_AUDITTABLE("metastore.housekeeping.leader.auditTable",
"metastore.housekeeping.leader.auditTable", "",
- "Audit the Metastore leader changes to the target table when
configured."),
+ "Audit the leader election event to a plain json table when
configured."),
+
METASTORE_HOUSEKEEPING_LEADER_NEW_AUDIT_FILE("metastore.housekeeping.leader.newAuditFile",
+ "metastore.housekeeping.leader.newAuditFile", false,
+ "Whether to create a new audit file in response to the new election
event " +
+ "when the metastore.housekeeping.leader.auditTable is not empty.\n" +
+ "True for creating a new file, false otherwise."),
+
METASTORE_HOUSEKEEPING_LEADER_AUDIT_FILE_LIMIT("metastore.housekeeping.leader.auditFiles.limit",
+ "metastore.housekeeping.leader.auditFiles.limit", 10,
Review Comment:
Is there a limitation on the file size for each file? If there is no limit,
I think we should enforce some limits on file size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
