SourabhBadhya commented on code in PR #4491:
URL: https://github.com/apache/hive/pull/4491#discussion_r1274496356
##########
standalone-metastore/metastore-server/src/main/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java:
##########
@@ -77,15 +77,14 @@ public static ValidTxnList
createValidTxnListForCleaner(GetOpenTxnsResponse txns
break;
}
if (abortedBits.get(i)) {
- exceptions[i] = txnId;
+ exceptions[i++] = txnId;
} else {
if (isAbortCleanup) {
- exceptions[i] = txnId;
+ exceptions[i++] = txnId;
} else {
- assert false : JavaUtils.txnIdToString(txnId) + " is open and <=
hwm:" + highWatermark;
+ assert (minOpenTxn == Long.MAX_VALUE) :
JavaUtils.txnIdToString(txnId) + " is open and <= hwm:" + highWatermark;
Review Comment:
AFAIK, if an open txn is present and it is not added to the exceptions list
or not failed, then it is treated as a valid txn when fetching the associated
write IDs.
Source -
https://github.com/apache/hive/blob/master/storage-api/src/java/org/apache/hadoop/hive/common/ValidReadTxnList.java#L71-L77
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
