deniskuzZ commented on code in PR #4491:
URL: https://github.com/apache/hive/pull/4491#discussion_r1284171478
##########
ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/handler/TaskHandler.java:
##########
@@ -121,7 +122,8 @@ protected ValidReaderWriteIdList
getValidCleanerWriteIdList(CompactionInfo info,
// been some delta/base dirs
assert rsp != null && rsp.getTblValidWriteIdsSize() == 1;
- return
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0));
+ return new ValidCleanerWriteIdList(
+
TxnCommonUtils.createValidReaderWriteIdList(rsp.getTblValidWriteIds().get(0)));
Review Comment:
it's just used in 1 single place, i would prefer not to create 1 more util
method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
