nrg4878 commented on code in PR #4475:
URL: https://github.com/apache/hive/pull/4475#discussion_r1283940834
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/HiveDatabaseAccessor.java:
##########
@@ -56,4 +57,19 @@ protected String addLimitToQuery(String sql, int limit) {
}
return sql + " LIMIT " + limit;
}
+
+ @Override
+ protected List<String> getColNamesFromRS(ResultSet rs) throws Exception {
+ List<String> columnNames = super.getColNamesFromRS(rs);
+ return columnNames.stream()
+ .map(c -> {
+ int lastIndex = c.lastIndexOf(".");
+ return lastIndex == -1 ? c : c.substring(lastIndex + 1); })
+ .collect(Collectors.toList());
+ }
+
+ @Override
+ protected String getMetaDataQuery(String sql) {
+ return addLimitToQuery(sql, 0);
Review Comment:
@akshat0395 Does this explanation answer your question? limit 1 returns a
row but we are just looking for row metadata from the result set.
This method is being overridden in this class because we want to use a limit
0 vs limit 1 that the parent class uses. Are you suggesting we change the
GenericJdbcDatabaseAccessor.addLimitToQuery() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
