nrg4878 commented on code in PR #4475:
URL: https://github.com/apache/hive/pull/4475#discussion_r1283946417
##########
jdbc-handler/src/main/java/org/apache/hive/storage/jdbc/dao/JdbcRecordIterator.java:
##########
@@ -52,7 +51,8 @@ public class JdbcRecordIterator implements
Iterator<Map<String, Object>> {
private String[] hiveColumnNames;
List<TypeInfo> hiveColumnTypesList;
- public JdbcRecordIterator(Connection conn, PreparedStatement ps, ResultSet
rs, Configuration conf) throws HiveJdbcDatabaseAccessException {
+ public JdbcRecordIterator(GenericJdbcDatabaseAccessor accessor, Connection
conn,
Review Comment:
General comment, not something this patch introduced. I wish these
Connection/PreparedStatement/ResultSet objects were not being passed in but
instead were accessible thru the accessor object. Makes a bit more sense IMHO.
This code can just call into the accessor object for cleanup as well instead of
doing it here.
What do you think? (I am not suggesting that we do this in this patch)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
