dengzhhu653 commented on code in PR #4520: URL: https://github.com/apache/hive/pull/4520#discussion_r1285588235
########## ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java: ########## @@ -1039,7 +1039,7 @@ public static List<String> mergeUniqElems(List<String> src, List<String> dest) { return src; } - private static final String tmpPrefix = "_tmp."; + private static final String tmpPrefix = "-tmp."; private static final String taskTmpPrefix = "_task_tmp."; Review Comment: Some ideas about the change: - The "-tmp" output would be visible to user if HS2 fails to delete the directory(non-partition external table) - Duplicated records might happen if the merge task reads all output files under "-tmp" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org For additional commands, e-mail: gitbox-h...@hive.apache.org