SourabhBadhya commented on code in PR #4520:
URL: https://github.com/apache/hive/pull/4520#discussion_r1293098033
##########
ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java:
##########
@@ -4552,7 +4553,7 @@ private static Path getManifestDir(Path specPath, long
writeId, int stmtId, Stri
if (isDelete) {
deltaDir = AcidUtils.deleteDeltaSubdir(writeId, writeId, stmtId);
}
- Path manifestPath = new Path(manifestRoot, "_tmp." + deltaDir);
+ Path manifestPath = new Path(manifestRoot, Utilities.toTempPath(deltaDir));
Review Comment:
@deniskuzZ I dont think it is a good idea to isolate specifically for CTAS
since it is embedded within FileSinkOperator. I would keep this directory
generic for all write operations.
Even if we do it specifically, then we have to introduce more logic for
handling CTAS cases and this might not be a fault tolerant approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscr...@hive.apache.org
For additional commands, e-mail: gitbox-h...@hive.apache.org
