abstractdog commented on code in PR #4630:
URL: https://github.com/apache/hive/pull/4630#discussion_r1306920924
##########
standalone-metastore/metastore-common/src/main/java/org/apache/hadoop/hive/common/metrics/metrics2/CodahaleMetrics.java:
##########
@@ -414,6 +415,7 @@ private boolean initCodahaleMetricsReporterClasses() {
try {
// Note: Hadoop metric reporter does not support tags. We create a
single reporter for all metrics.
Constructor<?> constructor = name.getConstructor(MetricRegistry.class,
Configuration.class);
+ if (name.getName().equals(Metrics2Reporter.class.getName()))
DefaultMetricsSystem.shutdown();
Review Comment:
we tend to format branches into separate lines, regardless of the length of
the blocks
```
if (name.getName().equals(Metrics2Reporter.class.getName())){
DefaultMetricsSystem.shutdown();
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
