mayankkunwar commented on code in PR #4630:
URL: https://github.com/apache/hive/pull/4630#discussion_r1306929416
##########
standalone-metastore/metastore-common/src/test/java/org/apache/hadoop/hive/common/metrics/metrics2/TestCodahaleMetrics.java:
##########
@@ -74,7 +74,9 @@ public static void setUp() throws Exception {
conf.set(MetastoreConf.ConfVars.METRICS_CLASS.getHiveName(),
CodahaleMetrics.class.getCanonicalName());
conf.set(MetastoreConf.ConfVars.HIVE_CODAHALE_METRICS_REPORTER_CLASSES.getHiveName(),
"org.apache.hadoop.hive.common.metrics.metrics2.JsonFileMetricsReporter, "
- +
"org.apache.hadoop.hive.common.metrics.metrics2.JmxMetricsReporter");
+ +
"org.apache.hadoop.hive.common.metrics.metrics2.JmxMetricsReporter, "
+ +
"org.apache.hadoop.hive.common.metrics.metrics2.Metrics2Reporter, "
Review Comment:
Yes, adding the Metrics2Reporter twice causes the exception that is
mentioned in the Jira ticket. And this is handled as part of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
